Skip to content

DOC: PDEP6 page format update #53442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jun 1, 2023
Merged

DOC: PDEP6 page format update #53442

merged 16 commits into from
Jun 1, 2023

Conversation

UmbertoFasci
Copy link
Contributor

@UmbertoFasci UmbertoFasci commented May 29, 2023 •
edited
Loading

@github-actions
Copy link
Contributor

No preview found for PR #53442. Did the docs build complete?

@UmbertoFasci UmbertoFasci changed the title DOC: PDP6 page bulleted list update #53414 DOC: PDEP6 page bulleted list update #53414 May 29, 2023
@UmbertoFasci UmbertoFasci changed the title DOC: PDEP6 page bulleted list update #53414 DOC: PDEP6 page bulleted list update May 29, 2023
@github-actions
Copy link
Contributor

No preview found for PR #53442. Did the docs build complete?

@UmbertoFasci
Copy link
Contributor Author

UmbertoFasci commented May 29, 2023 •
edited
Loading

@MarcoGorelli, here is the link to preview the change:

https://pandas.pydata.org/preview/53442/pdeps/0006-ban-upcasting.html

77d7834 updates the list format for the occurrence which was mentioned in the issue.
ddf551a updates the entire document format where bulleted lists are suggested.
b976bc5 fixes unintended deletion.
478e2e9 includes a ' for (Series' dtype) in line 12 reflecting grammar rules expressed in line 92.
9f345e8 includes formatting for numbered list, and punctuation for list objects where appropriate.
fa8cf3a includes proper formatting for nested list (2) in detailed description section of PDEP6.
7722182 includes final formatting changes utilizing local build, resulting in accurate rendering.

@UmbertoFasci UmbertoFasci mentioned this pull request May 29, 2023
Closed
1 task
@UmbertoFasci UmbertoFasci changed the title DOC: PDEP6 page bulleted list update DOC: PDEP6 page format update May 29, 2023
@UmbertoFasci UmbertoFasci marked this pull request as draft May 30, 2023 01:15
@UmbertoFasci UmbertoFasci marked this pull request as ready for review May 30, 2023 04:48
@MarcoGorelli MarcoGorelli added the Web pandas website label May 30, 2023
@MarcoGorelli MarcoGorelli added this to the 2.1 milestone May 30, 2023
MarcoGorelli
MarcoGorelli approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks really good, thanks @UmbertoFasci !

Just a couple of places don't look quite right:

image

image

MarcoGorelli
MarcoGorelli suggested changes May 30, 2023
View reviewed changes
MarcoGorelli
MarcoGorelli approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one, thanks @UmbertoFasci

@MarcoGorelli MarcoGorelli merged commit bd58d5b into pandas-dev:main Jun 1, 2023
@UmbertoFasci UmbertoFasci deleted the issue#53414 branch June 4, 2023 01:13
topper-123 pushed a commit to topper-123/pandas that referenced this pull request Jun 5, 2023
@UmbertoFasci @topper-123
DOC: PDEP6 page format update (pandas-dev#53442)
cf26781 
* DOC: PDP6 page bulleted list update pandas-dev#53414

* PDEP6 full format update pandas-dev#53414

* PDEP6 final bullet list updated pandas-dev#53414

* Fix unintended deletion pandas-dev#53414

* Grammar fix

* PDEP6 numbered list and object puncuation. pandas-dev#53414

* Update nested list in description section.

* PDEP6 Final Commit Proposal for Review. pandas-dev#53414

* PDEP6 update code block format FAQ. pandas-dev#53414

* PDEP6 whitespace cleanup pandas-dev#53414

* PDEP6 FAQ code block update pandas-dev#53414

* PDEP6 format update for final review. pandas-dev#53414

* PDEP6 final review with whitespace fix

* PDEP6 FAQ section typo fix.
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@UmbertoFasci
DOC: PDEP6 page format update (pandas-dev#53442)
caf3006 
* DOC: PDP6 page bulleted list update pandas-dev#53414

* PDEP6 full format update pandas-dev#53414

* PDEP6 final bullet list updated pandas-dev#53414

* Fix unintended deletion pandas-dev#53414

* Grammar fix

* PDEP6 numbered list and object puncuation. pandas-dev#53414

* Update nested list in description section.

* PDEP6 Final Commit Proposal for Review. pandas-dev#53414

* PDEP6 update code block format FAQ. pandas-dev#53414

* PDEP6 whitespace cleanup pandas-dev#53414

* PDEP6 FAQ code block update pandas-dev#53414

* PDEP6 format update for final review. pandas-dev#53414

* PDEP6 final review with whitespace fix

* PDEP6 FAQ section typo fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Web pandas website
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

DOC: PDEP6 page doesn't render correctly
2 participants
@UmbertoFasci @MarcoGorelli