Skip to content

REF/CLN: func in core.apply #53437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2023
Merged

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Replaces the conditional global currying with local currying where necessary. Also renames variables to use func consistently throughout core.apply.

cc @topper-123

@rhshadrach rhshadrach added Refactor Internal refactoring of code Clean Apply Apply, Aggregate, Transform, Map labels May 29, 2023
@mroeschke mroeschke added this to the 2.1 milestone May 30, 2023
@mroeschke mroeschke merged commit cee3aef into pandas-dev:main May 30, 2023
@mroeschke
Copy link
Member

Thanks @rhshadrach

@topper-123
Copy link
Contributor

Yes, this easier to follow. Nice one.

@rhshadrach rhshadrach deleted the no_currying_in_apply branch May 31, 2023 10:07
topper-123 pushed a commit to topper-123/pandas that referenced this pull request Jun 5, 2023
* REF/CLN: func in core.apply

* Remove type-hint
topper-123 pushed a commit to topper-123/pandas that referenced this pull request Jun 6, 2023
* REF/CLN: func in core.apply

* Remove type-hint
mroeschke pushed a commit that referenced this pull request Jun 7, 2023
* BUG: make Series.agg aggregate when possible

* fix doc build

* deprecate instead of treating as a bug

* CLN: Apply.agg_list_like

* some cleanups

* REF/CLN: func in core.apply (#53437)

* REF/CLN: func in core.apply

* Remove type-hint

* REF: Decouple Series.apply from Series.agg (#53400)

* update test

* fix issues

* fix issues

* fix issues

---------

Co-authored-by: Richard Shadrach <[email protected]>
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
* REF/CLN: func in core.apply

* Remove type-hint
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
* BUG: make Series.agg aggregate when possible

* fix doc build

* deprecate instead of treating as a bug

* CLN: Apply.agg_list_like

* some cleanups

* REF/CLN: func in core.apply (pandas-dev#53437)

* REF/CLN: func in core.apply

* Remove type-hint

* REF: Decouple Series.apply from Series.agg (pandas-dev#53400)

* update test

* fix issues

* fix issues

* fix issues

---------

Co-authored-by: Richard Shadrach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Apply Apply, Aggregate, Transform, Map Clean Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants