API: provide compat for Timestamp now/today/utcnow class methods (GH5339) #5342
Conversation
| @@ -140,6 +140,22 @@ class Timestamp(_Timestamp): | |||
| note: by definition there cannot be any tz info on the ordinal itself """ | |||
| return cls(datetime.fromordinal(ordinal),offset=offset,tz=tz) | |||
|
|
|||
| @classmethod | |||
There was a problem hiding this comment.
neat, didn't know you could use decorators in Cython at all...
There was a problem hiding this comment.
yep u can use them to tell cython not to check array bounds too, for example.
There was a problem hiding this comment.
ah, right the 'fake' cython decorators.
There was a problem hiding this comment.
they are real. like u said, cython implements decorators. i think cython is a superset of python so all of python is implemented, with the exception of assignment in the body of a class.
|
cc @JanSchulz , cc @Cancan01 any other methods you think are missing? |
|
@jreback it's cancan101 ! |
|
|
|
@cancan101 sorry...typo! |
|
@cancan101 ...want to add them? should be straightforward...just add tests and push to this PR! |
|
@cancan101 pls create a new issue for these other methods |
API: provide compat for Timestamp now/today/utcnow class methods (GH5339)
| """ compat now with datetime """ | ||
| if isinstance(tz, basestring): | ||
| tz = pytz.timezone(tz) | ||
| return cls(datetime.now(tz)) |
There was a problem hiding this comment.
@cpcloud so is this the right option here? Or should it just be "cls('now')"?
There was a problem hiding this comment.
it's fine the way it is and that would depend on dateutil parsing i think. i'd prefer to just depend on stdlib here ... but not super strong about it.
There was a problem hiding this comment.
this is what datetime does
closes #5339