DEPR: Deprecate literal json string input to read_json

doc/source/user_guide/io.rst

@@ -2072,6 +2072,7 @@ is ``None``. To explicitly force ``Series`` parsing, pass ``typ=series``
 * ``engine``: Either ``"ujson"``, the built-in JSON parser, or ``"pyarrow"`` which dispatches to pyarrow's ``pyarrow.json.read_json``.
   The ``"pyarrow"`` is only available when ``lines=True``
 
+
 The parser will raise one of ``ValueError/TypeError/AssertionError`` if the JSON is not parseable.
 
 If a non-default ``orient`` was used when encoding to JSON be sure to pass the same

doc/source/whatsnew/v2.1.0.rst

@@ -268,6 +268,7 @@ Deprecations
 - Deprecated allowing arbitrary ``fill_value`` in :class:`SparseDtype`, in a future version the ``fill_value`` will need to be compatible with the ``dtype.subtype``, either a scalar that can be held by that subtype or ``NaN`` for integer or bool subtypes (:issue:`23124`)
 - Deprecated behavior of :func:`assert_series_equal` and :func:`assert_frame_equal` considering NA-like values (e.g. ``NaN`` vs ``None`` as equivalent) (:issue:`52081`)
 - Deprecated constructing :class:`SparseArray` from scalar data, pass a sequence instead (:issue:`53039`)
+- Deprecated literal json input to :func:`read_json` (:issue:`53409`)
 - Deprecated positional indexing on :class:`Series` with :meth:`Series.__getitem__` and :meth:`Series.__setitem__`, in a future version ``ser[item]`` will *always* interpret ``item`` as a label, not a position (:issue:`50617`)
 -
 

pandas/io/json/_json.py

@@ -18,6 +18,7 @@
     TypeVar,
     overload,
 )
+import warnings
 
 import numpy as np
 
@@ -30,6 +31,7 @@
 from pandas.compat._optional import import_optional_dependency
 from pandas.errors import AbstractMethodError
 from pandas.util._decorators import doc
+from pandas.util._exceptions import find_stack_level
 from pandas.util._validators import check_dtype_backend
 
 from pandas.core.dtypes.common import ensure_str
@@ -535,6 +537,11 @@ def read_json(
         By file-like object, we refer to objects with a ``read()`` method,
         such as a file handle (e.g. via builtin ``open`` function)
         or ``StringIO``.
+
+        .. deprecated:: 2.1.0
+            Passing json literal strings will be deprecated in a future release of
+            pandas.
+
     orient : str, optional
         Indication of expected JSON string format.
         Compatible JSON strings can be produced by ``to_json()`` with a
@@ -925,7 +932,14 @@ def _get_data_from_filepath(self, filepath_or_buffer):
             and not file_exists(filepath_or_buffer)
         ):
             raise FileNotFoundError(f"File {filepath_or_buffer} does not exist")
-
+        else:
+            warnings.warn(
+                "Passing literal json to 'read_json' is deprecated and "
+                "will be removed in a future version. To read from a "
+                "literal string, wrap it in a 'StringIO' object.",
+                FutureWarning,
+                stacklevel=find_stack_level(),
+            )
         return filepath_or_buffer
 
     def _combine_lines(self, lines) -> str:

pandas/tests/io/json/test_compression.py

@@ -9,6 +9,14 @@
 from pandas.tests.io.test_compression import _compression_to_extension
 
 
+def generateDepMsg():
+    return (
+        "Passing literal json to 'read_json' is deprecated and "
+        "will be removed in a future version. To read from a "
+        "literal string, wrap it in a 'StringIO' object."
+    )
+
+
 def test_compression_roundtrip(compression):
     df = pd.DataFrame(
         [[0.123456, 0.234567, 0.567567], [12.32112, 123123.2, 321321.2]],
@@ -23,7 +31,8 @@ def test_compression_roundtrip(compression):
         # explicitly ensure file was compressed.
         with tm.decompress_file(path, compression) as fh:
             result = fh.read().decode("utf8")
-        tm.assert_frame_equal(df, pd.read_json(result))
+        with tm.assert_produces_warning(FutureWarning, match=generateDepMsg()):
+            tm.assert_frame_equal(df, pd.read_json(result))
 
 
 def test_read_zipped_json(datapath):
@@ -40,8 +49,8 @@ def test_read_zipped_json(datapath):
 @pytest.mark.single_cpu
 def test_with_s3_url(compression, s3_resource, s3so):
     # Bucket "pandas-test" created in tests/io/conftest.py
-
-    df = pd.read_json('{"a": [1, 2, 3], "b": [4, 5, 6]}')
+    with tm.assert_produces_warning(FutureWarning, match=generateDepMsg()):
+        df = pd.read_json('{"a": [1, 2, 3], "b": [4, 5, 6]}')
 
     with tm.ensure_clean() as path:
         df.to_json(path, compression=compression)
@@ -56,15 +65,17 @@ def test_with_s3_url(compression, s3_resource, s3so):
 
 def test_lines_with_compression(compression):
     with tm.ensure_clean() as path:
-        df = pd.read_json('{"a": [1, 2, 3], "b": [4, 5, 6]}')
+        with tm.assert_produces_warning(FutureWarning, match=generateDepMsg()):
+            df = pd.read_json('{"a": [1, 2, 3], "b": [4, 5, 6]}')
         df.to_json(path, orient="records", lines=True, compression=compression)
         roundtripped_df = pd.read_json(path, lines=True, compression=compression)
         tm.assert_frame_equal(df, roundtripped_df)
 
 
 def test_chunksize_with_compression(compression):
     with tm.ensure_clean() as path:
-        df = pd.read_json('{"a": ["foo", "bar", "baz"], "b": [4, 5, 6]}')
+        with tm.assert_produces_warning(FutureWarning, match=generateDepMsg()):
+            df = pd.read_json('{"a": ["foo", "bar", "baz"], "b": [4, 5, 6]}')
         df.to_json(path, orient="records", lines=True, compression=compression)
 
         with pd.read_json(
@@ -75,7 +86,8 @@ def test_chunksize_with_compression(compression):
 
 
 def test_write_unsupported_compression_type():
-    df = pd.read_json('{"a": [1, 2, 3], "b": [4, 5, 6]}')
+    with tm.assert_produces_warning(FutureWarning, match=generateDepMsg()):
+        df = pd.read_json('{"a": [1, 2, 3], "b": [4, 5, 6]}')
     with tm.ensure_clean() as path:
         msg = "Unrecognized compression type: unsupported"
         with pytest.raises(ValueError, match=msg):

pandas/tests/io/json/test_deprecated_kwargs.py

@@ -8,9 +8,17 @@
 from pandas.io.json import read_json
 
 
+def generateDepMsg():
+    return (
+        "Passing literal json to 'read_json' is deprecated and "
+        "will be removed in a future version. To read from a "
+        "literal string, wrap it in a 'StringIO' object."
+    )
+
+
 def test_good_kwargs():
     df = pd.DataFrame({"A": [2, 4, 6], "B": [3, 6, 9]}, index=[0, 1, 2])
-    with tm.assert_produces_warning(None):
+    with tm.assert_produces_warning(FutureWarning, match=generateDepMsg()):
         tm.assert_frame_equal(df, read_json(df.to_json(orient="split"), orient="split"))
         tm.assert_frame_equal(
             df, read_json(df.to_json(orient="columns"), orient="columns")

pandas/tests/io/json/test_json_table_schema.py

@@ -24,6 +24,14 @@
 )
 
 
+def generateDepMsg():
+    return (
+        "Passing literal json to 'read_json' is deprecated and "
+        "will be removed in a future version. To read from a "
+        "literal string, wrap it in a 'StringIO' object."
+    )
+
+
 @pytest.fixture
 def df_schema():
     return DataFrame(
@@ -254,7 +262,8 @@ def test_read_json_from_to_json_results(self):
                 "name_en": {"row_0": "Hakata Dolls Matsuo"},
             }
         )
-        result1 = pd.read_json(df.to_json())
+        with tm.assert_produces_warning(FutureWarning, match=generateDepMsg()):
+            result1 = pd.read_json(df.to_json())
         result2 = DataFrame.from_dict(json.loads(df.to_json()))
         tm.assert_frame_equal(result1, df)
         tm.assert_frame_equal(result2, df)
@@ -795,7 +804,8 @@ def test_comprehensive(self):
         )
 
         out = df.to_json(orient="table")
-        result = pd.read_json(out, orient="table")
+        with tm.assert_produces_warning(FutureWarning, match=generateDepMsg()):
+            result = pd.read_json(out, orient="table")
         tm.assert_frame_equal(df, result)
 
     @pytest.mark.parametrize(
@@ -811,15 +821,17 @@ def test_multiindex(self, index_names):
         )
         df.index.names = index_names
         out = df.to_json(orient="table")
-        result = pd.read_json(out, orient="table")
+        with tm.assert_produces_warning(FutureWarning, match=generateDepMsg()):
+            result = pd.read_json(out, orient="table")
         tm.assert_frame_equal(df, result)
 
     def test_empty_frame_roundtrip(self):
         # GH 21287
         df = DataFrame(columns=["a", "b", "c"])
         expected = df.copy()
         out = df.to_json(orient="table")
-        result = pd.read_json(out, orient="table")
+        with tm.assert_produces_warning(FutureWarning, match=generateDepMsg()):
+            result = pd.read_json(out, orient="table")
         tm.assert_frame_equal(expected, result)
 
     def test_read_json_orient_table_old_schema_version(self):
@@ -841,5 +853,6 @@ def test_read_json_orient_table_old_schema_version(self):
         }
         """
         expected = DataFrame({"a": [1, 2.0, "s"]})
-        result = pd.read_json(df_json, orient="table")
+        with tm.assert_produces_warning(FutureWarning, match=generateDepMsg()):
+            result = pd.read_json(df_json, orient="table")
         tm.assert_frame_equal(expected, result)

pandas/tests/io/json/test_json_table_schema_ext_dtype.py

@@ -33,6 +33,14 @@
 )
 
 
+def generateDepMsg():
+    return (
+        "Passing literal json to 'read_json' is deprecated and "
+        "will be removed in a future version. To read from a "
+        "literal string, wrap it in a 'StringIO' object."
+    )
+
+
 class TestBuildSchema:
     def test_build_table_schema(self):
         df = DataFrame(
@@ -287,7 +295,8 @@ def test_json_ext_dtype_reading_roundtrip(self):
         )
         expected = df.copy()
         data_json = df.to_json(orient="table", indent=4)
-        result = read_json(data_json, orient="table")
+        with tm.assert_produces_warning(FutureWarning, match=generateDepMsg()):
+            result = read_json(data_json, orient="table")
         tm.assert_frame_equal(result, expected)
 
     def test_json_ext_dtype_reading(self):
@@ -311,6 +320,7 @@ def test_json_ext_dtype_reading(self):
                 }
             ]
         }"""
-        result = read_json(data_json, orient="table")
+        with tm.assert_produces_warning(FutureWarning, match=generateDepMsg()):
+            result = read_json(data_json, orient="table")
         expected = DataFrame({"a": Series([2, NA], dtype="Int64")})
         tm.assert_frame_equal(result, expected)