-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
PERF: Do not init cache in RangeIndex.take #53397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jbrockmendel
merged 9 commits into
pandas-dev:main
from
GianlucaFicarelli:range_index_take
Jul 18, 2023
Merged
PERF: Do not init cache in RangeIndex.take #53397
jbrockmendel
merged 9 commits into
pandas-dev:main
from
GianlucaFicarelli:range_index_take
Jul 18, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb5ba30
to
21dd222
Compare
0b4497d
to
964a190
Compare
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
bbe2658
to
155e572
Compare
jbrockmendel
reviewed
Jul 7, 2023
7ff5a04
to
1def1ee
Compare
c720a9c
to
241bf69
Compare
Improve performance when passing an array to RangeIndex.take, DataFrame.loc, or DataFrame.iloc and the DataFrame is using a RangeIndex
…e and fill_value is not None
This reverts commit 102644c.
241bf69
to
637d168
Compare
Couple questions, otherwise LGTM |
Thanks, I've answered all the pending questions. |
jbrockmendel
approved these changes
Jul 18, 2023
thanks @GianlucaFicarelli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Indexing
Related to indexing on series/frames, not to indexes themselves
Performance
Memory or execution speed performance
Stale
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve performance when passing an array to RangeIndex.take, DataFrame.loc, or DataFrame.iloc and the DataFrame is using a RangeIndex
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Performance test:
Output (pandas 2.0.1):
Output (this PR):