DOC: Adjust build command for building with meson #53392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change default command to show verbose output. Otherwise, it might be confusing for users when the import hangs and their CPU goes to 100% during the rebuild step.
|
Tested this and now I get verbose output when importing pandas triggers meson to do things. |
| # By default, this will print verbose output | ||
| # showing the "rebuild" taking place on import (see section below for explanation) | ||
| # If you do not want to see this, omit everything after --no-build-isolation | ||
| python -m pip install -ve . --no-build-isolation --config-settings editable-verbose=true |
There was a problem hiding this comment.
Somehow unrelated to the changes here, but when I pip install -e . I need to call Python from the same directory where I call pip install. So, what I do is pip install -e $(pwd) which adds the current package to the environment regardless of the current directory. Is people just happy to call python always from the pandas directory, or am I missing something? I feel that suggesting $(pwd) here in the docs could be better if the same happens to everyone.
WillAyd
approved these changes
Jun 1, 2023
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
Jun 5, 2023
Change default command to show verbose output. Otherwise, it might be confusing for users when the import hangs and their CPU goes to 100% during the rebuild step.
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
Change default command to show verbose output. Otherwise, it might be confusing for users when the import hangs and their CPU goes to 100% during the rebuild step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change default command to show verbose output, as discussed during the dev call.
Otherwise, it might be confusing for users when the import hangs and their CPU goes to 100% during the rebuild step.
cc @ngoldbaum
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.