Refactor Extension Modules #53346
Merged
Refactor Extension Modules #53346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
commented
May 22, 2023
| 'include_dirs': inc_datetime} | ||
| 'np_datetime': {'sources': ['np_datetime.pyx']}, | ||
| 'offsets': {'sources': ['offsets.pyx']}, | ||
| 'parsing': {'sources': ['parsing.pyx', '../src/parser/tokenizer.c']}, |
There was a problem hiding this comment.
I'm not sure why this still needs tokenizer.c as a source - should be replaced via the capsule import but likely missed
mroeschke
approved these changes
May 24, 2023
|
Thanks @WillAyd |
|
Just merged main and now im getting build errors (my builds in general have gotten a lot more troublesome since the meson change, dont know if this is related) |
|
Try to wipe your build folder and start from scratch with meson. I don't know that meson handles changes in the file system that gracefully compared to our old methodology |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
Jun 5, 2023
* Working refactor with setuptools * Meson updates * fixed missing source files * Missing graft
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* Working refactor with setuptools * Meson updates * fixed missing source files * Missing graft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts all source files in
pandas/_libs/srcand all header files inpandas/_libs/includeThis simplifies our includes, letting us do them in an "absolute" way, while also making it clear which headers/sources were vendored