Skip to content

Change Naming Scheme of Series #53312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 22, 2023
Merged

Change Naming Scheme of Series #53312

merged 5 commits into from
May 22, 2023

Conversation

austinburnett
Copy link
Contributor

@austinburnett austinburnett commented May 19, 2023 •
edited by MarcoGorelli
Loading

closes #53271

Checklist:

  • I modified all versions of series with the naming scheme s to ser.
  • pre-commit checks pass.

@austinburnett austinburnett mentioned this pull request May 19, 2023
Closed
4 tasks
@austinburnett austinburnett mentioned this pull request May 19, 2023
Closed
1 task
@austinburnett
Copy link
Contributor Author

austinburnett commented May 19, 2023 •
edited
Loading

It looks like all the pre-commit checks are passing on my end when I run:

pre-commit run --files

pre-commit run --all-files pass as well

@MarcoGorelli
Copy link
Member

thanks but there's already an open PR, please find another issue to contribute to

@MarcoGorelli
Copy link
Member

wait, sorry, my bad - looks like you'd expressed interest before the other contributor - reopening this one and closing the other one then

@MarcoGorelli MarcoGorelli reopened this May 20, 2023
@DeaMariaLeon
Copy link
Member

/preview

@github-actions
Copy link
Contributor

Website preview of this PR available at: https://pandas.pydata.org/preview/53312/

@DeaMariaLeon
Copy link
Member

Well done @austinburnett !
LGTM but we need someone else with the super powers to merge (and double check).
Like @MarcoGorelli maybe?

@MarcoGorelli MarcoGorelli self-requested a review May 20, 2023 14:14
@austinburnett
Copy link
Contributor Author

Well done @austinburnett ! LGTM but we need someone else with the super powers to merge (and double check). Like @MarcoGorelli maybe?

Thank you! LGTM! I look forward to contributing more to Pandas!

@MarcoGorelli MarcoGorelli added this to the 2.1 milestone May 22, 2023
MarcoGorelli
MarcoGorelli approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one, thanks @austinburnett (and Dea for reviewing!)

@MarcoGorelli MarcoGorelli merged commit dd11d47 into pandas-dev:main May 22, 2023
@austinburnett
Copy link
Contributor Author

Hahahah thanks @MarcoGorelli. I look forward to contributing more to Pandas!

topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 22, 2023
@austinburnett @topper-123
Change Naming Scheme of Series (pandas-dev#53312)
aecf156 
* Change naming scheme of series from s to ser

* Change naming scheme of series from s to ser

* Change naming scheme of series from s to ser

* Change naming scheme of series from s to ser
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@austinburnett
Change Naming Scheme of Series (pandas-dev#53312)
61376de 
* Change naming scheme of series from s to ser

* Change naming scheme of series from s to ser

* Change naming scheme of series from s to ser

* Change naming scheme of series from s to ser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

DOC: Change "Convention for examples" to use Series name as ser instead of s
3 participants
@austinburnett @MarcoGorelli @DeaMariaLeon