Skip to content

CI: Pin Numba<0.57 in ARM build #53309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 20, 2023
Merged

CI: Pin Numba<0.57 in ARM build #53309

merged 4 commits into from
May 20, 2023

Conversation

mroeschke
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added CI Continuous Integration ARM aarch64 architecture labels May 19, 2023
@lithomas1
Copy link
Member

@mroeschke
I see numba 0.57.0 dropped on conda-forge just under a day ago. Maybe pinning might help?

The segfault comes from test_numba_vs_cython.

@mroeschke mroeschke added this to the 2.0.2 milestone May 20, 2023
@mroeschke mroeschke marked this pull request as ready for review May 20, 2023 00:20
@mroeschke mroeschke changed the title CI: Debug ARM Segfault CI: Pin Numba<0.57 in ARM build May 20, 2023
@phofl phofl merged commit 9d38f40 into pandas-dev:main May 20, 2023
@phofl
Copy link
Member

phofl commented May 20, 2023

thx @mroeschke

@lumberbot-app
Copy link

lumberbot-app bot commented May 20, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 9d38f40767da08ff46b807fd9565666a7aaf079c
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #53309: CI: Pin Numba<0.57 in ARM build'
  1. Push to a named branch:
git push YOURFORK 2.0.x:auto-backport-of-pr-53309-on-2.0.x
  1. Create a PR against branch 2.0.x, I would have named this PR:

"Backport PR #53309 on branch 2.0.x (CI: Pin Numba<0.57 in ARM build)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

phofl pushed a commit to phofl/pandas that referenced this pull request May 20, 2023
@mroeschke mroeschke deleted the ci/debug/arm branch May 20, 2023 17:38
lithomas1 pushed a commit that referenced this pull request May 20, 2023
…53318)

CI: Pin Numba<0.57 in ARM build (#53309)

(cherry picked from commit 9d38f40)

Co-authored-by: Matthew Roeschke <[email protected]>
topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 22, 2023
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARM aarch64 architecture CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants