Skip to content

FIX RangeIndex rsub by constant #53288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 18, 2023
Merged

FIX RangeIndex rsub by constant #53288

merged 3 commits into from
May 18, 2023

Conversation

Charlie-XIAO
Copy link
Contributor

@Charlie-XIAO Charlie-XIAO commented May 18, 2023 •
edited
Loading

topper-123
topper-123 approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@topper-123 topper-123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@topper-123 topper-123 added Bug Numeric Operations Arithmetic, Comparison, and Logical operations Index Related to the Index class or subclasses labels May 18, 2023
@topper-123 topper-123 added this to the 2.1 milestone May 18, 2023
@topper-123 topper-123 merged commit c871284 into pandas-dev:main May 18, 2023
@topper-123
Copy link
Contributor

Nice. Thanks @Charlie-XIAO.

topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 22, 2023
@Charlie-XIAO @topper-123
FIX RangeIndex rsub by constant (pandas-dev#53288)
f7d7ccc 
* FIX RangeIndex rsub by constant

* changelog added

* resolved conversations; take neg only for rsub
@Charlie-XIAO Charlie-XIAO deleted the fix-rangeindex-rsub branch June 28, 2023 05:41
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@Charlie-XIAO
FIX RangeIndex rsub by constant (pandas-dev#53288)
e6c6443 
* FIX RangeIndex rsub by constant

* changelog added

* resolved conversations; take neg only for rsub
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

@topper-123 topper-123 topper-123 approved these changes

Assignees
No one assigned
Labels
Bug Index Related to the Index class or subclasses Numeric Operations Arithmetic, Comparison, and Logical operations
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

BUG: RangeIndex has zero length after subtraction from constant value
3 participants
@Charlie-XIAO @topper-123 @jbrockmendel