DOC: Corrected code_checks.sh #53266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ci/code_checks.sh
Outdated
| @@ -83,6 +83,7 @@ if [[ -z "$CHECK" || "$CHECK" == "docstrings" ]]; then | |||
| pandas.Series.backfill \ | |||
| pandas.Series.ffill \ | |||
| pandas.Series.pad \ | |||
| pandas.Series.dt.end_time \ | |||
There was a problem hiding this comment.
thanks for updating - looks like the check passes even with this in, are we sure we need it?
There was a problem hiding this comment.
looks like Series.dt.end_time inherits the docstrings from Period.end_time
rather than doing complicated 4D code gymnastics to share docstrings, shall we just put the examples together? a bit like you did for some other examples, like
For period:
>>> [current example]
For Series:
>>> [example for Series.dt.end_time]
Then we can remove both from code_checks
There was a problem hiding this comment.
Thanks - I saw this after I arrived to the same conclusion (but slower 🫤)
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 22, 2023
* Corrected code_checks.sh * Added example for Series.dt.end_time * Update pandas/_libs/tslibs/period.pyx --------- Co-authored-by: Marco Edward Gorelli <[email protected]>
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* Corrected code_checks.sh * Added example for Series.dt.end_time * Update pandas/_libs/tslibs/period.pyx --------- Co-authored-by: Marco Edward Gorelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #37875