Skip to content

CLN: Fix typo in parameter name, standardize a bit #53253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 17, 2023
+3 −3
Merged

CLN: Fix typo in parameter name, standardize a bit #53253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b92d93
CLN: Fix typo in parameter name, standardize a bit
deepyaman May 16, 2023
d222f2b
Update test_merge_asof.py
deepyaman May 16, 2023
71d14b9
Merge branch 'main' into patch-2
deepyaman May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pandas/core/reshape/merge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1623,7 +1623,7 @@ def get_join_indexers(
"""
assert len(left_keys) == len(
right_keys
), "left_key and right_keys must be the same length"
), "left_keys and right_keys must be the same length"

# fast-path for empty left/right
left_n = len(left_keys[0])
Expand Down Expand Up @@ -1960,7 +1960,7 @@ def _validate_left_right_on(self, left_on, right_on):
self.right_by = [self.right_by]

if len(self.left_by) != len(self.right_by):
raise MergeError("left_by and right_by must be same length")
raise MergeError("left_by and right_by must be the same length")

left_on = self.left_by + list(left_on)
right_on = self.right_by + list(right_on)
Expand Down
2 changes: 1 addition & 1 deletion pandas/tests/reshape/merge/test_merge_asof.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ def test_multiby_indexed(self):
tm.assert_frame_equal(expected, result)

with pytest.raises(
MergeError, match="left_by and right_by must be same length"
MergeError, match="left_by and right_by must be the same length"
):
merge_asof(
left,
Expand Down