BUG DataFrameGroupBy.agg with list not respecting as_index=False
#53237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
reviewed
May 18, 2023
rhshadrach
requested changes
May 19, 2023
|
@rhshadrach Thanks for your review! New test added and I've made your suggested modification. |
mroeschke
approved these changes
May 22, 2023
|
Thanks @Charlie-XIAO |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 22, 2023
…andas-dev#53237) * fix dataframegroupby.agg not respecting as_index=false * cleaned up code, removed breakpoints * cleaning up codes * final cleanup of code, ready for review, sry abt that * resolve typing (not sure) * used better approach * new test added; enh short circuiting * clean up code
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
…andas-dev#53237) * fix dataframegroupby.agg not respecting as_index=false * cleaned up code, removed breakpoints * cleaning up codes * final cleanup of code, ready for review, sry abt that * resolve typing (not sure) * used better approach * new test added; enh short circuiting * clean up code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v2.1.0.rstfileDealing with non-categorical data is fairly easy, but dealing with categorical data is kind of tricky. I'm currently taking a pretty dirty approach, so if maintainers have better solutions please let me know and I'll make changes correspondingly.