DOC: Add note for building with setuptools #53227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithomas1
reviewed
May 14, 2023
| If pandas is already installed, you have to uninstall it first:: | ||
|
|
||
| pip uninstall pandas | ||
|
|
There was a problem hiding this comment.
I think it is good to add the context for why you should uninstall it.
e.g.
"This is because python setup.py develop will not uninstall the loader script that meson-python uses to import the extension from the build folder, which may cause errors such as an FileNotFoundError to be raised."
lithomas1
reviewed
May 14, 2023
bashtage
reviewed
May 14, 2023
| .. note:: | ||
| If pandas is already installed, you have to uninstall it first:: | ||
|
|
||
| pip uninstall pandas |
There was a problem hiding this comment.
Rather than raw pip, should you use python -m pip uninstall pandas, which seems to be more consistent with the rest of the page?
lithomas1
approved these changes
May 17, 2023
mroeschke
approved these changes
May 17, 2023
|
Thanks @phofl |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 22, 2023
* DOC: Add note for building with setuptools * Update doc/source/development/contributing_environment.rst Co-authored-by: Thomas Li <[email protected]> * Update --------- Co-authored-by: Thomas Li <[email protected]>
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* DOC: Add note for building with setuptools * Update doc/source/development/contributing_environment.rst Co-authored-by: Thomas Li <[email protected]> * Update --------- Co-authored-by: Thomas Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.