Skip to content

FIX typo in deprecation message of deprecate_kwarg decorator #53218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2023

Conversation

Charlie-XIAO
Copy link
Contributor

@Charlie-XIAO Charlie-XIAO commented May 13, 2023

Previously, the error message looks has an additional quotation mark, which I assume is a typo:

FutureWarning: the 'quantile'' keyword is deprecated, use 'q' instead.

Now it looks like this:

FutureWarning: the 'quantile' keyword is deprecated, use 'q' instead.

Btw, does this fix need a changelog?

@phofl phofl added the Clean label May 14, 2023
@phofl phofl added this to the 2.0.2 milestone May 14, 2023
@phofl phofl merged commit 1771b0f into pandas-dev:main May 14, 2023
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request May 14, 2023
@phofl
Copy link
Member

phofl commented May 14, 2023

thx @Charlie-XIAO, no need for a changelog entry

phofl pushed a commit that referenced this pull request May 14, 2023
…f `deprecate_kwarg` decorator) (#53222)

Backport PR #53218: FIX typo in deprecation message of `deprecate_kwarg` decorator

Co-authored-by: Yao Xiao <[email protected]>
Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 22, 2023
@Charlie-XIAO Charlie-XIAO deleted the fix-depr-kw-typo branch June 28, 2023 05:42
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants