DOC: add missing parameters to offsets classes: BYearEnd, BusinessHour, WeekOfMonth #53183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
approved these changes
May 16, 2023
There was a problem hiding this comment.
thanks @natmokval
I've changed this to "xref" instead of "closes", as there are still some classes where there are missing parameters
| The number of years represented. | ||
| normalize : bool, default False | ||
| Normalize start/end dates to midnight before generating date range. | ||
| month : int, default 1 |
There was a problem hiding this comment.
ah missed this, the default is actually 12, not 1 - fancy opening a follow-up to fix this?
There was a problem hiding this comment.
Thank you, @MarcoGorelli. I will open a new pr, add missing parameters to some classes and correct the default value for month.
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 22, 2023
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated documentation for offsets classes:
BYearEnd,BusinessHour,WeekOfMonth, added missing parameters.