Add asv benchmarks for Block.setitem() #53177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
May 11, 2023
asv_bench/benchmarks/block.py
Outdated
| (np.array(True), "np.array(True)"), | ||
| ] | ||
|
|
||
| def setup(self, true_value): |
There was a problem hiding this comment.
Could you move this to indexing.py?
mroeschke
reviewed
May 11, 2023
asv_bench/benchmarks/block.py
Outdated
|
|
||
| def time_test(self, true_value): | ||
| """Test time for assigning a slice `True` and `np.array(True)`""" | ||
| tmp_df = self.df.copy() |
and delete df.copy
|
Thank you for your response @mroeschke . I solved the issues as you told me , if there is anything else i can do let me know. |
|
Looks like the new benchmark is failing, please run it locally to see if it's working correctly https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#running-the-performance-test-suite |
|
I was able to resolve the issue on my local system. Thank you for your feedback @mroeschke |
mroeschke
reviewed
May 12, 2023
|
@mroeschke moved the import at the start of the file as you told me |
|
@mroeschke Looks like that the tests have passed now and i also moved the imports as you told me. If there is anything else i can do, please let me know. |
mroeschke
approved these changes
May 15, 2023
|
Thanks @steliospetrakis02 |
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
* Add test for groupby with TimeGrouper * add asv_bench for block * add asv_bench for block * Delete block.py , move class Block to indexing.py , as requested and delete df.copy * Add one more parameter to signarures seems to solve the issue * change name to mode * Move import to the start of the file
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 22, 2023
* Add test for groupby with TimeGrouper * add asv_bench for block * add asv_bench for block * Delete block.py , move class Block to indexing.py , as requested and delete df.copy * Add one more parameter to signarures seems to solve the issue * change name to mode * Move import to the start of the file
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* Add test for groupby with TimeGrouper * add asv_bench for block * add asv_bench for block * Delete block.py , move class Block to indexing.py , as requested and delete df.copy * Add one more parameter to signarures seems to solve the issue * change name to mode * Move import to the start of the file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block.setitem()whenvalueis a builtin python type. #25756 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.I believe that this solves the issue , however let me know if i need to change anything as i am not familliar with asv benchmarks