Skip to content

Switch to setup-micromamba #53168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2023
Merged

Switch to setup-micromamba #53168

merged 4 commits into from
May 12, 2023

Conversation

jonashaag
Copy link
Contributor

@jonashaag jonashaag commented May 10, 2023

We are deprecating provision-with-micromamba and replacing it with https://github.com/mamba-org/setup-micromamba.

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke mentioned this pull request May 11, 2023
5 tasks
@mroeschke mroeschke added the CI Continuous Integration label May 11, 2023
@mroeschke
Copy link
Member

Thanks looks pretty good. Could you merge in main once more and take out of draft mode?

@jonashaag jonashaag marked this pull request as ready for review May 11, 2023 16:41
@jonashaag
Copy link
Contributor Author

@pavelzw sorry for not synchronizing on this. I’ll merge your changes into this. Anything else I should include?

@jonashaag jonashaag marked this pull request as draft May 11, 2023 16:43
@pavelzw
Copy link

pavelzw commented May 11, 2023

No worries, I didn't see anything else that was not in my PR on first glance.

@jonashaag jonashaag marked this pull request as ready for review May 12, 2023 14:52
@jonashaag
Copy link
Contributor Author

Should be good when green

@mroeschke mroeschke added this to the 2.0.2 milestone May 12, 2023
@mroeschke mroeschke merged commit 2cce838 into pandas-dev:main May 12, 2023
@lumberbot-app
Copy link

lumberbot-app bot commented May 12, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 2cce8385a3d8822a2058fdd4a8228fe45baf0cd1
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #53168: Switch to setup-micromamba'
  1. Push to a named branch:
git push YOURFORK 2.0.x:auto-backport-of-pr-53168-on-2.0.x
  1. Create a PR against branch 2.0.x, I would have named this PR:

"Backport PR #53168 on branch 2.0.x (Switch to setup-micromamba)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@mroeschke
Copy link
Member

Sweet, thanks @jonashaag

@mroeschke
Copy link
Member

Noting based on the conflicts, I don't think we should backport this.

@mroeschke
Copy link
Member

mroeschke commented May 12, 2023

@jonashaag looks like extra-specs is not a valid argument in setup-micromamba what is the equivalent way to install environment packages ad hoc?

https://github.com/pandas-dev/pandas/actions/runs/4961454335/jobs/8878246555

@pavelzw
Copy link

pavelzw commented May 12, 2023

extra-specs: |
  a
  b
  c

should be changed to

create-args: >-
  a
  b
  c

@mroeschke
Copy link
Member

Thanks! I will create a PR to update this

@jonashaag
Copy link
Contributor Author

Whoops thanks

Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
* Switch to setup-micromamba

* Update package-checks.yml

* Update action.yml

* Update package-checks.yml
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
* Switch to setup-micromamba

* Update package-checks.yml

* Update action.yml

* Update package-checks.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants