BUG: from_dataframe with empty objects #53161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Arrow
| @@ -79,7 +79,9 @@ def _from_dataframe(df: DataFrameXchg, allow_copy: bool = True): | |||
| raise RuntimeError( | |||
| "To join chunks a copy is required which is forbidden by allow_copy=False" | |||
| ) | |||
| if len(pandas_dfs) == 1: | |||
| if not pandas_dfs: | |||
| pandas_df = pd.DataFrame({col: [] for col in df.column_names()}) | |||
There was a problem hiding this comment.
do we care about the dtype(s)?
There was a problem hiding this comment.
Good call. Using protocol_df_chunk_to_pandas here will preserve the dtypes
|
Going to merge, but happy to address any followups. |
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
* BUG: from_dataframe with empty objects * Use protocol_df_chunk_to_pandas
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 22, 2023
* BUG: from_dataframe with empty objects * Use protocol_df_chunk_to_pandas
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* BUG: from_dataframe with empty objects * Use protocol_df_chunk_to_pandas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.