MNT: Explicitly set cdef functions as noexcept #53144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matusvalo
force-pushed
the
cython3_noexcept
branch
from
9da685c to
d14b6d3
Compare
mroeschke
added
the
Internals
mroeschke
approved these changes
May 9, 2023
|
Thanks @matusvalo |
jonashaag
reviewed
May 13, 2023
| @@ -595,7 +595,7 @@ cdef check_overflows(_TSObject obj, NPY_DATETIMEUNIT reso=NPY_FR_ns): | |||
| # ---------------------------------------------------------------------- | |||
| # Localization | |||
|
|
|||
| cdef void _localize_tso(_TSObject obj, tzinfo tz, NPY_DATETIMEUNIT reso): | |||
| cdef void _localize_tso(_TSObject obj, tzinfo tz, NPY_DATETIMEUNIT reso) noexcept: | |||
There was a problem hiding this comment.
Is this really noexcept? I think the Localizer constructor can raise
There was a problem hiding this comment.
In Cython 0.29.X the default exception handling is noexcept hence the exception was not propagated even before this PR. If an exception should be propagated, one should consider changing return type from void to int to avoid checking exception after every function call.
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
* Explicitly set cdef functions as noexcept * Make linter happy
5 tasks
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* Explicitly set cdef functions as noexcept * Make linter happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This PR marks functions returning
voidasnoexceptto avoid checking an exception after every function call.inlinefunctions are marked too to avoid unnecessary overhead. The improvement is only in Cython 3. In Cython 0.29.Xnoexceptkeyword is ignored. See #53125 (comment) for details.