BUG: Setting frame into df with dup cols loses dtypes #53143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Indexing
mroeschke
reviewed
May 9, 2023
|
|
||
| def test_setitem_frame_dup_cols_dtype(self): | ||
| # GH#53143 | ||
| df = DataFrame([[1, 2, 3, 4], [4, 5, 6, 7]], columns=["a", "b", "a", "c"]) |
There was a problem hiding this comment.
What would happen if df has unique columns and rhs had duplicate columns?
There was a problem hiding this comment.
we only get there with a scalar key, e.g. if columns are unique you'll end up with a single column. This would raise since your rhs dimension is too large
mroeschke
approved these changes
May 9, 2023
|
Thanks @phofl |
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
* BUG: Setting frame into df with dup cols loses dtypes * BUG: Setting frame into df with dup cols loses dtypes * Fix mypy
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* BUG: Setting frame into df with dup cols loses dtypes * BUG: Setting frame into df with dup cols loses dtypes * Fix mypy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.