ENH: add validate parameter to Categorical.from_codes #53122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
May 7, 2023
| validate : bool, default True | ||
| If True, validate that the codes are valid for the dtype. | ||
| If False, don't validate that the codes are valid. | ||
|
|
There was a problem hiding this comment.
If you don’t validate you risk a segfault so user beware
mroeschke
approved these changes
May 9, 2023
|
Thanks @topper-123 |
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
* ENH: add validate parameter to Categorical.from_codes * add GH number * simplify a bit * add segfault warning
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* ENH: add validate parameter to Categorical.from_codes * add GH number * simplify a bit * add segfault warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validateparameter to 'Categorical.from_codes' get avoid validation when not needed #50975doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.