REF: define _header_line and have_mi_columns non-dynamically #53091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
May 5, 2023
| def _header_line(self): | ||
| # Store line for reuse in _get_index_name | ||
| if self.header is not None: | ||
| return None |
There was a problem hiding this comment.
Won't ncols = len(self._header_line) fail if this is hit?
There was a problem hiding this comment.
assuming you're referring to L543, it would, but the "else" on L542 ensures that we dont get there with self.header not-None.
mroeschke
approved these changes
May 5, 2023
|
Thanks @jbrockmendel |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 7, 2023
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to make this code a little less stateful. Not having much luck. Pushing what I have before it falls off the radar.