Skip to content

CI: Build wheel from sdist #53087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 85 commits into from
Jun 1, 2023
Merged

CI: Build wheel from sdist #53087

merged 85 commits into from
Jun 1, 2023

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented May 4, 2023

Builds the wheels for all platforms/Python versions from the sdist

Other changes:

  • Cleans up the wheel.yml file
  • Uses delvewheel to repair the windows wheels instead of manually patching
  • Tests windows wheels with windows-servercore directly in the wheels.yml file
  • Runs wheel unpack for every wheel for validation, not just windows wheels
  • Adds musllinux wheels per Request for musllinux wheels MacPython/pandas-wheels#176

@mroeschke mroeschke added Build Library building on various platforms CI Continuous Integration labels May 4, 2023
@mroeschke mroeschke marked this pull request as draft May 7, 2023 00:54
@mroeschke mroeschke requested a review from lithomas1 June 1, 2023 17:36
Copy link
Member

@lithomas1 lithomas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for pushing this through.

@mroeschke mroeschke merged commit c6700d5 into pandas-dev:main Jun 1, 2023
@mroeschke mroeschke deleted the ci/ref/wheel branch June 1, 2023 23:12
topper-123 pushed a commit to topper-123/pandas that referenced this pull request Jun 5, 2023
* CI: Build wheel from sdist

* Save sdist name to pass to ciwheelbuild

* Fix typo

* fix typo

* Check dist

* Another typo

* one more typo?

* Remove missing files in Manifest, checkout project

* try a different variable

* Try in the prior directory up

* check project folder

* Pull path

* Exclude some data files

* Replace test command

* Remove .data as well

* Install locale on musl

* Try delvewheel

* Run wheel unpack everywhere

* Skip in script

* Wheel unpack separately

* Invalid toml

* Run wheel unpack outside

* dont create dir

* Debug mac unpack, try alternative test

* Align

* for loop validate, try to fix -v

* for loop validate, try to fix -v

* Fix path

* Try pwd

* To root?

* Use another bash?

* try MSYS_NO_PATHCONV

* Add backslash

* Remove a slash

* Use powershell

* Use variable

* Typo

* Add other deps

* Final cleanups

* Remove unecessary select

* Try no

* Make multiline comment

* Put pack repo owner

* Try single

* clean step title

* Update to setup micromaba

* Use create-args

* Use create args

* Set PANDAS_CI

* Try running all on powershell

* Use ;

* Try this command

* Add double?

* try escpaing quotes

* Escape brackets?

* remove comma

* Single quotes

* Other quotes

* single?

* Backslash?

* All the escapes

* No marks

* Fix quotes

* test don't repair windows wheel

* Uncomment delvewheel
@lithomas1
Copy link
Member

@mroeschke

Do you know if this PR is related to the nightly failures?

From a glance, it looks like only macOS is failing sporadically, and with a different error every time.

Somehow the artifact is getting messed up(missing files I think).

Downloading the artifact from Github, it looks OK, so I'm thinking there's a race condition or something with uploading/downloading, but not sure where to keep look from here.

https://github.com/pandas-dev/pandas/actions/workflows/wheels.yml?query=event%3Aschedule

Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
* CI: Build wheel from sdist

* Save sdist name to pass to ciwheelbuild

* Fix typo

* fix typo

* Check dist

* Another typo

* one more typo?

* Remove missing files in Manifest, checkout project

* try a different variable

* Try in the prior directory up

* check project folder

* Pull path

* Exclude some data files

* Replace test command

* Remove .data as well

* Install locale on musl

* Try delvewheel

* Run wheel unpack everywhere

* Skip in script

* Wheel unpack separately

* Invalid toml

* Run wheel unpack outside

* dont create dir

* Debug mac unpack, try alternative test

* Align

* for loop validate, try to fix -v

* for loop validate, try to fix -v

* Fix path

* Try pwd

* To root?

* Use another bash?

* try MSYS_NO_PATHCONV

* Add backslash

* Remove a slash

* Use powershell

* Use variable

* Typo

* Add other deps

* Final cleanups

* Remove unecessary select

* Try no

* Make multiline comment

* Put pack repo owner

* Try single

* clean step title

* Update to setup micromaba

* Use create-args

* Use create args

* Set PANDAS_CI

* Try running all on powershell

* Use ;

* Try this command

* Add double?

* try escpaing quotes

* Escape brackets?

* remove comma

* Single quotes

* Other quotes

* single?

* Backslash?

* All the escapes

* No marks

* Fix quotes

* test don't repair windows wheel

* Uncomment delvewheel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants