Skip to content

CLN: clean Apply._try_aggregate_string_function #53079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 18, 2023
Merged

CLN: clean Apply._try_aggregate_string_function #53079

merged 3 commits into from
May 18, 2023

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 commented May 4, 2023 •
edited
Loading

@mroeschke mroeschke added Clean Apply Apply, Aggregate, Transform, Map labels May 4, 2023
rhshadrach
rhshadrach reviewed May 4, 2023
View reviewed changes
rhshadrach
rhshadrach approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach
Copy link
Member

@topper-123 - been a while since the tests ran, so just being cautious (paranoid? 😆) and wanted to kick them off again. Will merge on green.

@mroeschke mroeschke added this to the 2.1 milestone May 18, 2023
@mroeschke mroeschke merged commit eb4658f into pandas-dev:main May 18, 2023
@mroeschke
Copy link
Member

Thanks @topper-123

@topper-123 topper-123 deleted the cln_Apply._try_aggregate_string_function branch May 18, 2023 16:49
topper-123 added a commit to topper-123/pandas that referenced this pull request May 22, 2023
@topper-123 @rhshadrach
CLN: clean Apply._try_aggregate_string_function (pandas-dev#53079)
0ab6bd4 
* CLN: Apply._try_aggregate_string_function

* rename _try_aggregate_string_function -> _apply_string_function

---------

Co-authored-by: Richard Shadrach <[email protected]>
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@topper-123 @rhshadrach
CLN: clean Apply._try_aggregate_string_function (pandas-dev#53079)
7baa432 
* CLN: Apply._try_aggregate_string_function

* rename _try_aggregate_string_function -> _apply_string_function

---------

Co-authored-by: Richard Shadrach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Apply Apply, Aggregate, Transform, Map Clean
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@topper-123 @rhshadrach @mroeschke