Added test for sort_index parameter multiindex 'sort_remaining' = False #53076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please ensure you run precommit to fix code check issues: https://pandas.pydata.org/docs/development/contributing_codebase.html#contributing-pre-commit |
|
Hi @mroeschke :) |
phofl
reviewed
May 5, 2023
|
|
||
| @pytest.mark.parametrize("ascending", [True, False]) | ||
| def test_sort_index_multiindex_sort_remaining(self, ascending): | ||
| # GH #24247, testing multiindex sort_remaining=false consistent behavior |
There was a problem hiding this comment.
You can remove the comment except the gh reference
phofl
reviewed
May 5, 2023
| df_sorted = df.sort_index(level=1, sort_remaining=False, ascending=ascending) | ||
|
|
||
| if ascending: | ||
| df_expected = DataFrame( |
phofl
reviewed
May 5, 2023
| ), | ||
| ) | ||
|
|
||
| # Assert that the resulting DataFrame is sorted correctly |
|
Hi @phofl |
|
You didn't address any of my comments |
Sorry, I forgot to commit :) |
phofl
approved these changes
May 6, 2023
|
thx @NoyHanan |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 7, 2023
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue fixed on main, added validation tests