CI: Add job to validate conda-forge meta.yaml #53027
Conversation
mroeschke
added
Build
There was a problem hiding this comment.
Thanks for working on this @mroeschke, this will make the releases much less stressful.
I added couple of comments, but looks great.
ci/meta.yaml
Outdated
| url: https://github.com/pandas-dev/pandas/releases/download/v{{ version }}/pandas-{{ version }}.tar.gz | ||
| sha256: 19b8e5270da32b41ebf12f0e7165efa7024492e9513fb46fb631c5022ae5709d |
There was a problem hiding this comment.
I guess we may want to build the package with the lastest pandas from git, not the latest version? Not sure if this will fail when new dependencies are added or similar things, and Dask seems to do that:
https://github.com/dask/dask/blob/main/continuous_integration/recipe/meta.yaml#L11
There was a problem hiding this comment.
Ah I see. Good call I'll change this
| @@ -0,0 +1,88 @@ | |||
| {% set version = "2.0.1" %} | |||
There was a problem hiding this comment.
I'm unusure about the file name. Using the original/standard one makes sense. But at the same time, without more context inside ci/ the file name is not very descriptive. Totally up to you, just a thought, but since we specify the file name when calling conda mambabuild maybe naming this ci/conda-recipe.yml would be better?
There was a problem hiding this comment.
Good idea. I renamed it to ci/conda-recipe.yml
There was a problem hiding this comment.
I had to change this back to meta.yaml to be recognized by conda mambabuild
|
Going to merge this in, but happy to address any followups |
…ge meta.yaml) (#53146) Backport PR #53027: CI: Add job to validate conda-forge meta.yaml Co-authored-by: Matthew Roeschke <[email protected]>
|
Thanks for this @mroeschke, looks great! |
* CI: Add job to validate conda-forge meta.yaml * Rename file, test from git * Fix typo * fix concurrency * rename to meta.yaml, test over python versions * Fix recipe, add python version to job name * Try using mambabuild verify directly * seperate test from build * Add check, and save to specific output location * Skip verify step * Check if it's in package * Try specifying another folder * Try local * Give full path? * Check where the package is * Whats in noarch? * check linux-64 * Skip --test * only run during main and 2.0 checks * update meta
* CI: Add job to validate conda-forge meta.yaml * Rename file, test from git * Fix typo * fix concurrency * rename to meta.yaml, test over python versions * Fix recipe, add python version to job name * Try using mambabuild verify directly * seperate test from build * Add check, and save to specific output location * Skip verify step * Check if it's in package * Try specifying another folder * Try local * Give full path? * Check where the package is * Whats in noarch? * check linux-64 * Skip --test * only run during main and 2.0 checks * update meta
xref #52794 (comment) cc @datapythonista
Inspired by https://github.com/dask/dask/blob/main/.github/workflows/conda.yml