Skip to content

REF: simplify maybe_convert_objects #53021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2023

Conversation

jbrockmendel
Copy link
Member

convert_timedelta/datetime/period/interval are in practice either all-True or all-False so this combines them into a single keyword convert_nonnumeric. This will also prevent bloat if/when we add time/date/decimal/string/...

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added Refactor Internal refactoring of code Internals Related to non-user accessible pandas implementation labels May 2, 2023
@mroeschke mroeschke added this to the 2.1 milestone May 2, 2023
@mroeschke mroeschke merged commit aee55c9 into pandas-dev:main May 2, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the cln-maybe_convert_objects branch May 2, 2023 19:39
topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 7, 2023
Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants