TST: Add a test for multiindex df with na value and adding a new row #53010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shteken
changed the title
|
Hi, |
mroeschke
reviewed
May 1, 2023
pandas/tests/test_multilevel.py
Outdated
Comment on lines
301
to
302
| ) | ||
| df.set_index(["pivot_0", "pivot_1"], inplace=True) |
There was a problem hiding this comment.
Suggested change
| ) | |
| df.set_index(["pivot_0", "pivot_1"], inplace=True) | |
| ).set_index(["pivot_0", "pivot_1"]) |
There was a problem hiding this comment.
May I ask what benefit do we gain from chaining the operations?
There was a problem hiding this comment.
We want to avoid inplace=True where possible
mroeschke
reviewed
May 1, 2023
pandas/tests/test_multilevel.py
Outdated
|
|
||
| df.at[("A", "F"), "col_2"] = 0.0 | ||
|
|
||
| assert df.loc[("A", "F")]["col_2"] == 0.0 |
There was a problem hiding this comment.
Instead of these asserts, could you construct expected = DataFrame(...) and then use tm.assert_frame_equal(df, expected)
There was a problem hiding this comment.
Yes. I understand that with your suggestion it would be easier to understand the expected output.
mroeschke
approved these changes
May 3, 2023
|
Thanks @shteken |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 7, 2023
…pandas-dev#53010) * add test_multiindex_with_na * address comments in pr
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
…pandas-dev#53010) * add test_multiindex_with_na * address comments in pr
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
…pandas-dev#53010) * add test_multiindex_with_na * address comments in pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.