BLD: Split out tests into pandas_tests package #53007
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,6 +46,7 @@ jobs: | |
| IS_SCHEDULE_DISPATCH: ${{ github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' }} | ||
| outputs: | ||
| sdist_file: ${{ steps.save-path.outputs.sdist_name }} | ||
| pandas_tests_loc: ${{ steps.save-tests-path.outputs.pandas_tests_loc }} | ||
| steps: | ||
| - name: Checkout pandas | ||
| uses: actions/checkout@v4 | ||
|
|
@@ -59,22 +60,34 @@ jobs: | |
|
|
||
| - name: Build sdist | ||
| run: | | ||
| python -m pip install build wheel setuptools-scm | ||
| python -m build --sdist | ||
|
|
||
| - name: Build pandas_tests | ||
| run: | | ||
| cd pandas | ||
| # we want to place the pandas_tests wheel in the same | ||
| # dist directory as the sdist | ||
| python -m build --wheel --outdir ../dist --no-isolation | ||
|
|
||
| - uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: sdist-and-tests | ||
| path: ./dist/* | ||
|
|
||
| - name: Sanity check built files | ||
| run: | | ||
| ls ./dist | ||
|
|
||
| - name: Output sdist name | ||
| id: save-path | ||
| shell: bash -el {0} | ||
| run: echo "sdist_name=$(ls ./dist/*.tar.gz)" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Output pandas_tests location | ||
| id: save-tests-path | ||
| shell: bash -el {0} | ||
| run: echo "pandas_tests_loc=$(ls ./dist/*.whl)" >> "$GITHUB_OUTPUT" | ||
|
|
||
| build_wheels: | ||
| needs: build_sdist | ||
|
|
@@ -109,52 +122,48 @@ jobs: | |
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Download sdist and pandas_tests | ||
| uses: actions/download-artifact@v4 | ||
| with: | ||
| name: sdist-and-tests | ||
| path: ./dist | ||
|
|
||
| # The sdist will be corrupted by cibuildwheel/macOS sometimes somehow | ||
WillAyd marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # (I think this is a Github Actions bug) | ||
| - name: Unzip sdist (macOS) | ||
| if: ${{ startsWith(matrix.buildplat[1], 'macosx') }} | ||
| run: | | ||
| tar -xzf ${{ needs.build_sdist.outputs.sdist_file }} -C ./dist | ||
|
|
||
| - name: Output new sdist name (macOS) | ||
| id: save-path2 | ||
| if: ${{ matrix.buildplat[1] == 'macosx_*' }} | ||
| shell: bash -el {0} | ||
| run: echo "sdist_name=./dist/$(cd ./dist && ls -d */)" >> "$GITHUB_ENV" | ||
|
|
||
| - name: Build normal wheels | ||
| if: ${{ (env.IS_SCHEDULE_DISPATCH != 'true' || env.IS_PUSH == 'true') }} | ||
| uses: pypa/[email protected] | ||
| with: | ||
| package-dir: ${{ startsWith(matrix.buildplat[1], 'macosx') && env.sdist_name || needs.build_sdist.outputs.sdist_file }} | ||
| env: | ||
| CIBW_PRERELEASE_PYTHONS: True | ||
| CIBW_BUILD: ${{ matrix.python[0] }}-${{ matrix.buildplat[1] }} | ||
| # Note: Since the sdist is the project directory, it does not contain the tests | ||
WillAyd marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # We need to manually install tests from the host. This isn't ideal since it breaks | ||
| # isolation but should be no big deal | ||
| # (On Linux, need to prefix with /host, since we run builds in a container and the root directory is | ||
| # mounted to host) | ||
| CIBW_BEFORE_TEST: > | ||
| pip install ${{ startsWith(matrix.buildplat[0], 'ubuntu') && '/host'|| '' }}${{ github.workspace }}/${{ needs.build_sdist.outputs.pandas_tests_loc }} | ||
|
|
||
| - name: Build nightly wheels (with NumPy pre-release) | ||
| if: ${{ (env.IS_SCHEDULE_DISPATCH == 'true' && env.IS_PUSH != 'true') }} | ||
| uses: pypa/[email protected] | ||
| with: | ||
| package-dir: ./dist/${{ startsWith(matrix.buildplat[1], 'macosx') && env.sdist_name || needs.build_sdist.outputs.sdist_file }} | ||
| env: | ||
| # The nightly wheels should be build with the NumPy 2.0 pre-releases | ||
| # which requires the additional URL. | ||
| CIBW_ENVIRONMENT: PIP_EXTRA_INDEX_URL=https://pypi.anaconda.org/scientific-python-nightly-wheels/simple | ||
| CIBW_PRERELEASE_PYTHONS: True | ||
|
|
@@ -185,13 +194,15 @@ jobs: | |
| $TST_CMD = @" | ||
| python -m pip install hypothesis>=6.46.1 pytest>=7.3.2 pytest-xdist>=2.2.0; | ||
| python -m pip install `$(Get-Item pandas\wheelhouse\*.whl); | ||
| python -m pip install `$(Get-Item pandas\dist\pandas_tests*.whl); | ||
| python -c `'import pandas as pd; pd.test(extra_args=[`\"--no-strict-data-files`\", `\"-m not clipboard and not single_cpu and not slow and not network and not db`\"])`'; | ||
| "@ | ||
| # add rc to the end of the image name if the Python version is unreleased | ||
| docker pull python:${{ matrix.python[1] == '3.12' && '3.12-rc' || format('{0}-windowsservercore', matrix.python[1]) }} | ||
| docker run --env PANDAS_CI='1' -v ${PWD}:C:\pandas python:${{ matrix.python[1] == '3.12' && '3.12-rc' || format('{0}-windowsservercore', matrix.python[1]) }} powershell -Command $TST_CMD | ||
|
|
||
| - uses: actions/upload-artifact@v4 | ||
| if: always() | ||
| with: | ||
| name: ${{ matrix.python[0] }}-${{ matrix.buildplat[1] }} | ||
| path: ./wheelhouse/*.whl | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is setuptools-scm a misnomer or does it have some kind of dependency with setuptools?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use it to version the pandas-tests package?
Setting up versioneer is probably overkill for pandas-tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm not sure I understand. So this does still require setuptools right? I think that is confusing given the work we have put into meson to replace that library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, pandas-tests is built using setuptools.
I figured it was much easier to use setuptools given this is a pure Python package.
(Note that if you're just doing regular development you'll never need setuptools, unless you want to build pandas_tests by hand for some reason)