Skip to content

CLN/TYP: stronger typing in safe_sort #52973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@rhshadrach rhshadrach added Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Clean Typing type annotations, mypy/pyright type checking labels Apr 28, 2023
@mroeschke mroeschke added this to the 2.1 milestone Apr 28, 2023
@mroeschke mroeschke merged commit 768cd71 into pandas-dev:main Apr 28, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the cln-safe_sort branch April 28, 2023 17:03
topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 7, 2023
* CLN/TYP: stronger typing in safe_sort

* mypy fixup
Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
* CLN/TYP: stronger typing in safe_sort

* mypy fixup
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
* CLN/TYP: stronger typing in safe_sort

* mypy fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Clean Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants