-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Fix np.inf + np.nan sum issue on groupby mean #52964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 13 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
c8153c9
BUG: Fix np.inf + np.nan sum issue on groupby mean
parthi-siva 5a0f44b
Merge branch 'main' into BUG-GH#50367
parthi-siva 575e80a
BUG: Change variable name
parthi-siva 60a0279
TST: add test case to validate the fix
parthi-siva 6ff9f58
Merge branch 'main' into BUG-GH#50367
parthi-siva 9938e4f
Merge branch 'main' into BUG-GH#50367
parthi-siva 323dd11
Bug: Set Compensation to 0 when it is NaN
parthi-siva 1fc174e
TST: Fix failing test
parthi-siva cac4d72
Merge branch 'main' into BUG-GH#50367
parthi-siva dea7d19
Remove Space
parthi-siva 8244835
Merge branch 'main' into BUG-GH#50367
parthi-siva 6f3e64e
Add Comments
parthi-siva cf50206
TST: assign expected to seperate variable
parthi-siva 9339817
Merge branch 'main' into BUG-GH#50367
parthi-siva ac407dd
Update comment
parthi-siva 7beb278
Merge branch 'main' into BUG-GH#50367
parthi-siva b7b9dc3
Merge branch 'main' into BUG-GH#50367
parthi-siva 7bbc20f
Merge branch 'main' into BUG-GH#50367
parthi-siva 3c02170
TST: Fix issue with Linux32 dtype ValueError
parthi-siva 8943cda
Merge branch 'main' into BUG-GH#50367
parthi-siva d5ed2a2
Merge branch 'main' into BUG-GH#50367
parthi-siva c0c26eb
Merge branch 'main' into BUG-GH#50367
rhshadrach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is to check for nan? can you use an explicit check? If not, please add a comment about what you're doing and why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jbrockmendel, I tried do it explicitly but it is not working. I tried to use
utils.is_nan
since it isno gil
it is not compiling. So I just used this way to determine Nan (That's what we are doing inutils.is_nan
as well.)I will add appropriate comment in the code