CLN Dont upcast where unnecessary (PDEP6 precursor) #52957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Apr 27, 2023
| @@ -205,18 +205,24 @@ def use_numexpr(use, min_elements=None) -> Generator[None, None, None]: | |||
| set_option("compute.use_numexpr", olduse) | |||
|
|
|||
|
|
|||
| def raises_chained_assignment_error(): | |||
| if PYPY: | |||
| def raises_chained_assignment_error(extra_warnings=(), extra_match=()): | |||
There was a problem hiding this comment.
here I'm giving raises_chained_assignment_error the ability to catch extra warnings (as this will be used later in #50626)
phofl
approved these changes
Apr 27, 2023
|
thx @MarcoGorelli |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
Apr 27, 2023
This was referenced May 4, 2023
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 7, 2023
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
precursor to https://github.com/pandas-dev/pandas/pull/50626/files, trying to reduce the diff
there's some example / tests in which upcasting from int to float happens, but where it's not the purpose of what's being shown / tested. similar to #50493