-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
WEB: add mastodon links #52954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WEB: add mastodon links #52954
Conversation
/preview |
No preview found for PR #52954. Did the docs build complete? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @mikix
Any reason to have this PR as a draft? Can it be merged already?
There was a problem with the GitHub token and previews of the last couple of days aren't available. It should be fixed now, the preview for this PR should be available when the CI rerun finishes. |
@datapythonista it could be, but I had some ideas around ordering: In the api docs, the Twitter & mastodon links are currently in a different order than I put them on the web site. And the Twitter image is a (imo) distractingly bright blue — I was toying with unifying the order and appearance of the links in the api docs. But it has been fairly difficult to build them! Anyway, you can merge this if you like - I think it works OK — but I hadn’t just finished all my due diligence. |
Sure, no rush, I was just wondering if there was a reason. If it makes your life easier, we can also merge this now and you can work on those in a separate PR. But surely fine to continue here if you prefer. |
/preview |
Website preview of this PR available at: https://pandas.pydata.org/preview/52954/ |
Yeah you're right - this can be done incrementally - the current state is fine. I ran into another issue building the api docs, but I was able to confirm at least that the mastodon icon showed up. So this is good from my end. Will mark as ready. |
Thanks @mikix |
Co-authored-by: Marc Garcia <[email protected]>
Co-authored-by: Marc Garcia <[email protected]>
Co-authored-by: Marc Garcia <[email protected]>
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Sidebar:

Footer:
