CLN: Simplify to_masked implementation #52920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datapythonista
approved these changes
Apr 27, 2023
| else: | ||
| raise NotImplementedError | ||
|
|
||
| dtype = _arrow_dtype_mapping()[pa_dtype] |
There was a problem hiding this comment.
could we simplify even more by just doing self.dtype.numpy_dtype? Aside from that, LGTM
There was a problem hiding this comment.
I'd prefer keeping the mask stuff, this should make the conversion faster
jbrockmendel
approved these changes
Apr 28, 2023
mroeschke
approved these changes
Apr 28, 2023
|
Thanks @phofl |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 7, 2023
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.