added typing IntervalClosedType where needed #52894
Conversation
mroeschke
added
Interval
pandas/core/dtypes/dtypes.py
Outdated
| @@ -1099,7 +1100,7 @@ class IntervalDtype(PandasExtensionDtype): | |||
|
|
|||
| _cache_dtypes: dict[str_type, PandasExtensionDtype] = {} | |||
|
|
|||
| def __new__(cls, subtype=None, closed: str_type | None = None): | |||
| def __new__(cls, subtype=None, closed=None): | |||
There was a problem hiding this comment.
I tried, but I have an issue with mypy if I do this: it complains about the variable reassignement l.1141:
closed = gd["closed"]
pandas/core/dtypes/dtypes.py:1141: error: Incompatible types in assignment (expression has type "Union[str, Any]", variable has type "Optional[Union[Literal['left', 'right'], Literal['both', 'neither']]]") [assignment]
Do you know if there is a way to fix this?
There was a problem hiding this comment.
Adding # type: ignore[assignment] in 1141 would work here. This isn't ideal, but it's better if the function signature is typed more strictly
There was a problem hiding this comment.
I added what you suggested but I have a check that fails, I don't know why..
Do you have an idea of what's the reason?
|
this is unrelated, minimum versions is sometimes flaky |
|
thx @gmollard |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.@phofl