Call __finalize__ in Dataframe.combine and Dataframe.combine_first #52886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jinlixiao
commented
Apr 24, 2023
jinlixiao
commented
- resolves tasks in Various methods don't call call __finalize__ #28283
- remove not-implemented flag in tests
|
Here is my thought: In these two cases, I just let the attr from the first dataframe to propagate to the result. I think this is the most straightforward way and requires the least overhead. Let me know if this doesn't seem right. |
mroeschke
reviewed
Apr 24, 2023
mroeschke
approved these changes
Apr 25, 2023
|
Thanks @jinlixiao |
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
…andas-dev#52886) * Fixed metadata propagation in Dataframe.combine and Dataframe.combine_first * fix local var override
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
…andas-dev#52886) * Fixed metadata propagation in Dataframe.combine and Dataframe.combine_first * fix local var override
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.