Skip to content

Issue 21932: Added Regression Test for index of pivot_table on empty table #52809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 22, 2023
Merged

Issue 21932: Added Regression Test for index of pivot_table on empty table #52809

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
03ff6e8
add regression test
MirijaH Apr 20, 2023
fa265d8
iMerge branch 'main' into issue_21932
MirijaH Apr 20, 2023
090d02e
formatting
MirijaH Apr 21, 2023
359b8d5
format
MirijaH Apr 21, 2023
aec2e06
rm newlines
MirijaH Apr 21, 2023
198a1b1
changes from precommit
MirijaH Apr 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pandas/tests/reshape/test_pivot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2598,3 +2598,11 @@ def test_pivot_not_changing_index_name(self):
expected = df.copy(deep=True)
df.pivot(index="one", columns="two", values="three")
tm.assert_frame_equal(df, expected)

def test_pivot_table_empty_dataframe_correct_index(self):
# GH 21932
df = DataFrame([], columns=["a", "b", "value"])
pivot = df.pivot_table(index="a", columns="b", values="value", aggfunc="count")

expected = pd.Index([], dtype="object", name="b")
tm.assert_index_equal(pivot.columns, expected)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest you run pre-commit, please check the contributing guide for how to do that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the head up, done :)