Skip to content

TST: Regression test added for Timedelta #52748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 19, 2023
Merged

TST: Regression test added for Timedelta #52748

merged 5 commits into from
Apr 19, 2023

Conversation

MarvinGravert
Copy link
Contributor

@noatamir noatamir added the Sprints Sprint Pull Requests label Apr 18, 2023
jbrockmendel
jbrockmendel reviewed Apr 18, 2023
View reviewed changes
pandas/tests/frame/test_constructors.py Outdated
}
)
for _, row in foo.iterrows():
assert row.dtype == "object"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this probably belongs in tests.frame.methods.test_iterrows (which you'll have to create if it doesnt already exist)

@MarvinGravert MarvinGravert marked this pull request as ready for review April 19, 2023 19:05
@phofl phofl merged commit 6c56c88 into pandas-dev:main Apr 19, 2023
@phofl
Copy link
Member

phofl commented Apr 19, 2023

thx @MarvinGravert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Sprints Sprint Pull Requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: iterrows encounters OverflowError with str and datetime64[ns] columns
4 participants
@MarvinGravert @phofl @jbrockmendel @noatamir