Skip to content

GH31581 adding regression test #52740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 20, 2023
Merged

Conversation

corriebar
Copy link
Contributor

Worked on during the PyData workshop with @DrorBendet and @sven-simonsen. Tagging @phofl @noatamir @jorisvandenbossche @MarcoGorelli as reviewers.

@noatamir noatamir added the Sprints Sprint Pull Requests label Apr 18, 2023
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks @corriebar

@MarcoGorelli MarcoGorelli added this to the 2.1 milestone Apr 19, 2023
@MarcoGorelli MarcoGorelli added the Needs Tests Unit test(s) needed to prevent regressions label Apr 19, 2023
@mroeschke
Copy link
Member

Could you resolve the merge conflict?

@corriebar
Copy link
Contributor Author

Could you resolve the merge conflict?

resolved.

@phofl phofl merged commit f960208 into pandas-dev:main Apr 20, 2023
@phofl
Copy link
Member

phofl commented Apr 20, 2023

Thx @corriebar

@corriebar corriebar deleted the GH31581-regression-test branch April 20, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Tests Unit test(s) needed to prevent regressions Sprints Sprint Pull Requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assigning column with DataFrame(dtype='category') doesn't preserve categorical dtype, but Series does
5 participants