Added handling for v3 advanced segment ids which aren't just ints as of July 15th

[jcbozonier]

The old int based advanced segment ids are deprecated. The new segment ids are alphanumeric. I know from experimentation that their form includes alphanumeric and alphanumeric+hyphen. Updated code for both
cases. Reference: https://developers.google.com/analytics/devguides/reporting/core/v3/changelog

[jreback]

pls put these tests in the existing test_ga.py file
pls hook up Travis (see contributing.md)

[jcbozonier]

Ok. Updated tests... will check on Travis.

[jcbozonier]

OK. Travis build passed as well.

[jtratner]

Can you this down to one commit and rebase on master?

Also, does this break v2 support? (or is v2 no longer supported by Google?)

[jcbozonier]

Sure! How can I do the squash given the current state of my branch? Do I need to issue a new pull request?

As far as v2 goes this does not break v2 support. There are unit tests to support those cases as well in my code.

[jtratner]

Don't need a new PR, just squash and do git push --force

[jcbozonier]

Ok. All set!

[jtratner]

@jcbozonier one last thing - can you add a note to doc/source/release.rst that says you added support for v3 segment ids for GA? And then just do git commit --amend -C HEAD (amends your previous commit and keeps message) and push one more time, then I'll merge.

[jreback]

as an aside if you would like to they the exception messages when deps are not present and make a bit nicer

[jcbozonier]

Added a note. Also, I wanted to add a nicer exception but I wasn't sure how to do it in a way that was 2.6 AND 3.2 compatible. The next enhancement I make I'll take another stab at it.

[jtratner]

compatible exception is just:

raise ExceptionName("My error message"), whereas <= 2.6 syntax was raise ExceptionName, "error message". Is that what you mean?

[jtratner]

the former version is 2.6 - 3.X compatible

[jcbozonier]

Yeah I think so.

[jcbozonier]

Does it make more sense just to let it blow? Why even catch those exceptions?

[jtratner]

can you move this to the end of the section (b/c it's pretty much chronological) and add (:issue:'5271') to the end [but replace single quote with backticks], that'll make it end up with a link to this issue in the docs so someone who cares can find out more.

[jtratner]

it's basically just something like:

try:
   import <your dep>
except ImportError as e:
   raise ImportError("read_ga requires Google's ga package: %s" % str(e))

Your call - I'm +1 if you want to add a nice error message but I'll merge this after you make that slight to change to the docs note if you don't want to add it.

[jcbozonier]

I'm fine with adding that. To clarify, you mean to the split test file, right?

[jcbozonier]

err unit test*

[jtratner]

No - I think @jreback meant in the read_ga() method

[jtratner]

I guess you'll need to rebase this - apparently there's a merge conflict with something else (probably another PR that was merged in the interim)

[jcbozonier]

Rebase done.

[jtratner]

Thanks!