Skip to content

Fixed import error message when extensions not built #52674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2023

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Apr 14, 2023

From a quick glance at the newcomers slack channel this is the question people ask about most often. It looks like pandas.compat indirectly imports the _libs folder via util._dectorators grabbing cache_readonly, so our try...except never gets the chance to run.

It would be nice to add a test for this, not sure the cleanest way how

@MarcoGorelli
Copy link
Member

nice, thanks

I'd never seen this message 😄 Is --force the best advise to give though? Isn't it ok to just recommend the incremental build?

@WillAyd
Copy link
Member Author

WillAyd commented Apr 14, 2023

Never used force. I can update that too

@mroeschke mroeschke added the Error Reporting Incorrect or improved errors from pandas label Apr 14, 2023
@mroeschke mroeschke added this to the 2.1 milestone Apr 14, 2023
@mroeschke mroeschke merged commit 8b797e9 into pandas-dev:main Apr 14, 2023
@mroeschke
Copy link
Member

Thanks @WillAyd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants