BUG: Modify get_indexer_non_unique to account for nan keys #52655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Apr 15, 2023
| @@ -360,6 +360,8 @@ cdef class IndexEngine: | |||
| values = self.values | |||
| stargets = set(targets) | |||
|
|
|||
| na_in_stargets = any([checknull(t) for t in stargets]) | |||
There was a problem hiding this comment.
Suggested change
| na_in_stargets = any([checknull(t) for t in stargets]) | |
| na_in_stargets = any(checknull(t) for t in stargets) |
mroeschke
reviewed
Apr 15, 2023
| tm.assert_numpy_array_equal(np.array([0, 1, 3], dtype=np.intp), indexes) | ||
| tm.assert_numpy_array_equal(np.array([], dtype=np.intp), missing) | ||
|
|
||
| def test_get_indexer_non_unique_float_index(self): |
There was a problem hiding this comment.
Could you pytest.mark.parameterize this test with the one above?
mroeschke
reviewed
Apr 15, 2023
mroeschke
added
the
Missing-data
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeyError: '[nan] not in index'when usingnanto index #52234doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.