Skip to content

CI: Skip testing step in Pypy job #52638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 14, 2023
Merged

Conversation

mroeschke
Copy link
Member

@lithomas1 during today's dev call, I asked if we still need the Pypy build since it's actively failing (but passing in the CI) and no one is really ensuring we have compat with Pypy. Thought if we can remove it?

@mroeschke mroeschke added PyPy CI Continuous Integration labels Apr 12, 2023
@lithomas1
Copy link
Member

Can you just remove the testing phase instead?

We still build PyPy packages on conda (and pandas has failed to compile on PyPy come release time at least once).

@phofl
Copy link
Member

phofl commented Apr 12, 2023

The validate min versions script errors on the PyPy build, should investigate if we keep the file around

@mroeschke mroeschke changed the title CI: Remove Pypy build CI: Skip testing step in Pypy job Apr 12, 2023
@mroeschke
Copy link
Member Author

mroeschke commented Apr 12, 2023

Sure, let's just skip the testing steps of the Pypy jobs instead

But IIRC it doesn't look like our cibuildwheel is building for pypy which uploads to conda?

python: [["cp38", "3.8"], ["cp39", "3.9"], ["cp310", "3.10"], ["cp311", "3.11"]]# "pp38", "pp39"]

@jbrockmendel
Copy link
Member

cc @cfbolz we (pandas) don't have anyone championing pypy support. Can you suggest anyone from the pypy team who might be interested?

@lithomas1
Copy link
Member

Sure, let's just skip the testing steps of the Pypy jobs instead

But IIRC it doesn't look like our cibuildwheel is building for pypy which uploads to conda?

python: [["cp38", "3.8"], ["cp39", "3.9"], ["cp310", "3.10"], ["cp311", "3.11"]]# "pp38", "pp39"]

Although we upload PyPI wheels to Anaconda, we upload them to Anaconda's PyPI repositories, not the conda ones.

The conda packages are built separately by the pandas-feedstock repo, and the packages are built from the Github release tarball.
https://github.com/conda-forge/pandas-feedstock/blob/76269c33f5865e0642232cf9c73fdefb7f9412a7/recipe/meta.yaml#L8

@lithomas1 lithomas1 added this to the 2.0.1 milestone Apr 14, 2023
@mroeschke mroeschke merged commit f960825 into pandas-dev:main Apr 14, 2023
@mroeschke mroeschke deleted the ci/rm/pypy branch April 14, 2023 16:43
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Apr 14, 2023
mroeschke added a commit that referenced this pull request Apr 14, 2023
#52671)

Backport PR #52638: CI: Skip testing step in Pypy job

Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration PyPy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants