REGR: pivot changing index name of input object #52630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Reshaping
mroeschke
reviewed
Apr 12, 2023
| @@ -519,6 +519,8 @@ def pivot( | |||
| # If columns is None we will create a MultiIndex level with None as name | |||
| # which might cause duplicated names because None is the default for | |||
| # level names | |||
| data = data.copy(deep=False) | |||
| data.index = data.index.copy() | |||
| data.index.names = [ | |||
There was a problem hiding this comment.
Is there an opportunity to defer doing this (and avoiding the copy) if we push this to the if/else branches below?
There was a problem hiding this comment.
Both are shallow copies and should take any time compared to the actual pivot op?
There was a problem hiding this comment.
That's fair. Might be a cleanup opportunity in the future but ok as it fixes the regression
mroeschke
approved these changes
Apr 12, 2023
|
Thanks @phofl |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Apr 12, 2023
mroeschke
pushed a commit
that referenced
this pull request
Apr 12, 2023
…f input object) (#52636) Backport PR #52630: REGR: pivot changing index name of input object Co-authored-by: Patrick Hoefler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.