Skip to content

TYP: remove ignore from pandas/tseries/frequencies.py #52623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

TYP: remove ignore from pandas/tseries/frequencies.py #52623

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1d990b
remove mypy ignore[assignment] and cast index to TimedeltaArray
natmokval Apr 25, 2023
16e900f
Merge branch 'main' into 37715-remove-mypy-ignore-V
natmokval Apr 26, 2023
c90fc0e
Merge branch 'main' into 37715-remove-mypy-ignore-V
natmokval May 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions pandas/tseries/frequencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
from __future__ import annotations

from typing import TYPE_CHECKING
from typing import (
TYPE_CHECKING,
cast,
)

import numpy as np

Expand Down Expand Up @@ -51,6 +54,7 @@
Series,
TimedeltaIndex,
)
from pandas.core.arrays import TimedeltaArray
from pandas.core.arrays.datetimelike import DatetimeLikeArrayMixin
# ---------------------------------------------------------------------
# Offset names ("time rules") and related functions
Expand Down Expand Up @@ -140,10 +144,7 @@ def infer_freq(
>>> pd.infer_freq(idx)
'D'
"""
from pandas.core.api import (
DatetimeIndex,
Index,
)
from pandas.core.api import DatetimeIndex

if isinstance(index, ABCSeries):
values = index._values
Expand Down Expand Up @@ -172,15 +173,14 @@ def infer_freq(
inferer = _TimedeltaFrequencyInferer(index)
return inferer.get_freq()

if isinstance(index, Index) and not isinstance(index, DatetimeIndex):
if not hasattr(index, "dtype"):
pass
elif isinstance(index.dtype, object):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I'm not familiar enough with the code to review these code changes (more comfortable to review only type annotation changes)

if is_numeric_dtype(index.dtype):
raise TypeError(
f"cannot infer freq from a non-convertible index of dtype {index.dtype}"
)
# error: Incompatible types in assignment (expression has type
# "Union[ExtensionArray, ndarray[Any, Any]]", variable has type
# "Union[DatetimeIndex, TimedeltaIndex, Series, DatetimeLikeArrayMixin]")
index = index._values # type: ignore[assignment]
index = cast("TimedeltaArray", index)

if not isinstance(index, DatetimeIndex):
index = DatetimeIndex(index)
Expand Down