BUG: to_numeric(errors='coerce', dtype_backend='pyarrow') with ArrowDtype #52606
Conversation
pandas/core/tools/numeric.py
Outdated
| @@ -275,7 +275,8 @@ def to_numeric( | |||
| # GH33013: for IntegerArray, BooleanArray & FloatingArray need to reconstruct | |||
| # masked array | |||
| if (mask is not None or new_mask is not None) and not is_string_dtype(values.dtype): | |||
| if mask is None: | |||
| if mask is None or (new_mask is not None and errors == "coerce"): | |||
There was a problem hiding this comment.
Can't really think about a case right now, but I think new_mask.shape == mask.shape instead of errors="coerce" is safer
There was a problem hiding this comment.
Sure I'll change it to that
pandas/core/tools/numeric.py
Outdated
| @@ -275,7 +275,9 @@ def to_numeric( | |||
| # GH33013: for IntegerArray, BooleanArray & FloatingArray need to reconstruct | |||
| # masked array | |||
| if (mask is not None or new_mask is not None) and not is_string_dtype(values.dtype): | |||
| if mask is None or (new_mask is not None and errors == "coerce"): | |||
| if mask is None or ( | |||
| mask is not None and new_mask is not None and new_mask.shape == mask.shape | |||
There was a problem hiding this comment.
Can remove the mask is not None, this is covered by the first condition
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
|
@meeseeksmachine backport 2.0.x |
|
@meeseeksdev backport 2.0.x |
…backend='pyarrow') with ArrowDtype
…dtype_backend='pyarrow') with ArrowDtype) (#52611) Backport PR #52606: BUG: to_numeric(errors='coerce', dtype_backend='pyarrow') with ArrowDtype Co-authored-by: Matthew Roeschke <[email protected]>
pd.to_numeric(.., dtype_backend='pyarrow')crashes forstring[pyarrow]#52588 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.