TST: groupby string dtype #52599
Merged
TST: groupby string dtype #52599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Apr 11, 2023
pandas/tests/groupby/test_groupby.py
Outdated
| grouped = df.groupby("str_col", as_index=False) | ||
| avg = grouped.mean() | ||
| result = avg.dtypes[0] | ||
| tm.assert_equal(result, expected) |
There was a problem hiding this comment.
Could you instead compare the resulting DataFrame e.g.
result = df.groupby("str_col", as_index=False)
expected = DataFrame(...)
tm.assert_frame_equal(result, expected)
There was a problem hiding this comment.
Got it!
My bad I didn't know about assert_frame_equal. Thanks!
I read about it here, It will compare dtypes. Sounds good 👍
Are these the required changes?
expected = DataFrame({"str_col": ["a", "b", "c",], "num_col": [1.5, 2.0, 3.0]})
expected["str_col"] = expected['str_col'].astype("string")
result=grouped.mean()
tm.assert_frame_equal(result,expected)There was a problem hiding this comment.
Yes
Thanks for confirming.
mroeschke
added
the
Testing
mroeschke
approved these changes
Apr 12, 2023
|
Thanks @srkds |
|
Thanks @mroeschke for the review 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.