BUG: DatetimeArray.unit when constructed from a non-nano ndarray #52555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemanley
added
Bug
Non-Nano
mroeschke
reviewed
Apr 10, 2023
doc/source/whatsnew/v2.1.0.rst
Outdated
| @@ -219,6 +219,7 @@ Datetimelike | |||
| - Bug in :meth:`Timestamp.round` with values close to the implementation bounds returning incorrect results instead of raising ``OutOfBoundsDatetime`` (:issue:`51494`) | |||
| - :meth:`DatetimeIndex.map` with ``na_action="ignore"`` now works as expected. (:issue:`51644`) | |||
| - Bug in :meth:`arrays.DatetimeArray.map` and :meth:`DatetimeIndex.map`, where the supplied callable operated array-wise instead of element-wise (:issue:`51977`) | |||
| - Bug in :class:`arrays.DatetimeArray` constructor returning an incorrect unit when passed a non-nanosecond numpy datetime array (:issue:`52555`) | |||
There was a problem hiding this comment.
I think it would be okay to backport this to 2.0.1
There was a problem hiding this comment.
moved to 2.0.1 - thanks
mroeschke
approved these changes
Apr 11, 2023
mroeschke
approved these changes
Apr 11, 2023
|
Thanks @lukemanley |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Apr 11, 2023
…d from a non-nano ndarray
mroeschke
pushed a commit
that referenced
this pull request
Apr 11, 2023
…tructed from a non-nano ndarray) (#52608) Backport PR #52555: BUG: DatetimeArray.unit when constructed from a non-nano ndarray Co-authored-by: Luke Manley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v2.1.0.rstfile if fixing a bug or adding a new feature.fixes the following inconsistency: