Skip to content

TYP: remove ignore from pandas/core/groupby/groupby.py #52543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2023
Merged

TYP: remove ignore from pandas/core/groupby/groupby.py #52543

merged 2 commits into from
Apr 9, 2023
+3 −7

Conversation

natmokval
Copy link
Contributor

Related to #37715

mypy ignore[assignment] was removed from pandas/core/groupby/groupby.py

@natmokval natmokval marked this pull request as ready for review April 8, 2023 22:37
@natmokval natmokval requested a review from twoertwein April 9, 2023 07:12
@topper-123 topper-123 added Groupby Typing type annotations, mypy/pyright type checking labels Apr 9, 2023
@topper-123 topper-123 added this to the 2.1 milestone Apr 9, 2023
@topper-123 topper-123 merged commit 328a620 into pandas-dev:main Apr 9, 2023
@topper-123
Copy link
Contributor

Thanks @natmokval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topper-123 topper-123 topper-123 approved these changes

@twoertwein twoertwein Awaiting requested review from twoertwein

Assignees
No one assigned
Labels
Groupby Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@natmokval @topper-123